Hacktoberfest - My 1st

This is the first contribution I have made for Hacktoberfest.

The issue can be found here.
It is a new feature I think should involved into a credit card generator - credit card number validation.

Here is the pull request I have made.
I added a method with the submit click button.

The author merged it in 10 minutes. However I found the algorithm need to be improved. I will let the author know later. I think the merge need to be more precise?

I learned how to contribute on open source using git command.

Comments

Post a Comment

Popular posts from this blog

Hacktoberfest - My 2nd

This is the second contribution I have made for Hacktoberfest. It is a guess a number game. The issue can be found here . When I play this game, I found if I clicked the reset button, the difficult level come back to the default 1 to 100, but the radio option will stay at the previous one I chosen. Here is the pull request I have made. I add one line to set the radio option back to default, and also give the default option an id. Firstly, I searched on the website by how to reset the radio to default value. There are many way, more complicated than what I finally did. And I found the author try to do this things either. I even found the code he leaved as a common just as same as I tried. But those doesn't work. Then I went back to W3School to learn the radio button. I made it, quite simple:) I learned not always try to cut corners.
Read more

Project - Stage 0.1 - Project Selection

Pre-Selection This project is about optimize a open source project. Before I started to select a project, I browsed the articles gathering by Planet CDOT . It is "an open source blog Planet: an aggregated feed of blog posts from Seneca faculty and students working on open source in a single page." I am trying to find an area that I am interested in and contain projects that is straightforward and simple. One of my classmates choose to optimize a barcode project. I was inspired, QR code is used very frequently in my daily life (there is an application on my phone, the time I used it occupies 80% of the time I spend on phone). I always wondering how QR code works. Then I decided to find a project related to QR code. "QR code (abbreviated from Quick Response code) is the trademark for a type of matrix barcode (or two-dimensional barcode)." Selection Now I am searching open source project on Github.  I use the key words "qrcode", set language as C. T...
Read more