Project - Stage 3.0 - Pull Request

The last step is to pull request

The first optimize: https://github.com/gurushida/qrcode/pull/2
The second optimize: https://github.com/gurushida/qrcode/pull/1

and wait for the response from author.

Comments

Post a Comment

Popular posts from this blog

Project - Stage 1.0 - Project Optimize Plan

Previous Reading  Background Learning Project Performance Test Server used in this test is Aarch64 $ ssh siwen@aarchie.cdot.systems Fork and Clone from Github $ git clone https://github.com/SiwenFeng/qrcode.git $ cd qrcode Makefile $ make Benchmarking tool I am going to use is time. This project is about decoding, the faster the project can read a given QR code, the better the performance is. Because it is a local testing, the network speed has been ignored. $ time ./qrcode -v images/QR_damaged.png > output.html  Project Code Reading The original vision code is good enough to me. It contains almost every aspect I have learned about QR code. The decoding process include some repeat calculate. I guess change the way of calculation may influence the performance. Project Optimize Strategy The strategy I will use in Stage 2 to attempt to optimize is Algorithm improvements.
Read more

Project - Stage 2.2 - Project Optimize 2

Image
Previous Reading Project Optimize Plan The Second Algorithm Improvement In general, multiply or divide by an integer can get the result by shifting it. The multiply and divide method - generate left-shifted code if multiply by 2n, and multiply by any other integer or divide by any number. The shift method is more efficient than the multiplication and division method. binarize.c unsigned int averageNeighborBlackPoint = ... / 4   >>2
Read more

Code Review Processes Used In Open Source Projects

Project 1: vue vue is licensed under the MIT License. https://github.com/vuejs/vue/pull/10531 In this case, there are 3 participants involved in the review. One is the contributor, one is the reviewer, who is a member of vuejs. The last one is a robot. It took 2 days to finish the review. Actually, almost every request has been reviewed and finished in 2 days. I guess a standard survey before the request is help to improve the efficiency. It fixed link to point to ModuleOptions lines. Contributor changes js# L38-L45 to js# L47-L59. One member of  vuejs reviewed the change and approved it. After merged the change, the robot gave the contributor a thankful reply, also the reviewer. Project 2: octant octant is licensed under the Apache License 2.0. https://github.com/vmware/octant/pull/298 In this case, there are 4 participants involved in the review. It including 2 reviewers, 1 contributor and 1 VMware CLA Bot. It took 2 days to finish the review. There are so...
Read more