Code Review Processes Used In Open Source Projects

Project 1: vue

vue is licensed under the MIT License.
https://github.com/vuejs/vue/pull/10531

In this case, there are 3 participants involved in the review. One is the contributor, one is the reviewer, who is a member of vuejs. The last one is a robot. It took 2 days to finish the review. Actually, almost every request has been reviewed and finished in 2 days. I guess a standard survey before the request is help to improve the efficiency.
It fixed link to point to ModuleOptions lines. Contributor changes
js#L38-L45 to js#L47-L59. One member of  vuejs reviewed the change and approved it. After merged the change, the robot gave the contributor a thankful reply, also the reviewer.



Project 2: octant

octant is licensed under the Apache License 2.0.
https://github.com/vmware/octant/pull/298

In this case, there are 4 participants involved in the review. It including 2 reviewers, 1 contributor and 1 VMware CLA Bot. It took 2 days to finish the review. There are some discussion between the contributor and the reviewers. Also the bot added the cla-not-required label. 
It move namespaces which are overview specific to top level. Contributor basically remove modules/overview/ from the code. After it has been approved, another reviewer make a suggestion and the contributor made another change.

  • How many people were involved in the review
  • The role of those people in the community and project
  • How long the whole review took
  • How responsive the participants were to updates in the process
  • What kinds of issues were discussed
  • How issues were resolved

Comments

Post a Comment

Popular posts from this blog

Hacktoberfest - My 2nd

This is the second contribution I have made for Hacktoberfest. It is a guess a number game. The issue can be found here . When I play this game, I found if I clicked the reset button, the difficult level come back to the default 1 to 100, but the radio option will stay at the previous one I chosen. Here is the pull request I have made. I add one line to set the radio option back to default, and also give the default option an id. Firstly, I searched on the website by how to reset the radio to default value. There are many way, more complicated than what I finally did. And I found the author try to do this things either. I even found the code he leaved as a common just as same as I tried. But those doesn't work. Then I went back to W3School to learn the radio button. I made it, quite simple:) I learned not always try to cut corners.
Read more

Project - Stage 0.1 - Project Selection

Pre-Selection This project is about optimize a open source project. Before I started to select a project, I browsed the articles gathering by Planet CDOT . It is "an open source blog Planet: an aggregated feed of blog posts from Seneca faculty and students working on open source in a single page." I am trying to find an area that I am interested in and contain projects that is straightforward and simple. One of my classmates choose to optimize a barcode project. I was inspired, QR code is used very frequently in my daily life (there is an application on my phone, the time I used it occupies 80% of the time I spend on phone). I always wondering how QR code works. Then I decided to find a project related to QR code. "QR code (abbreviated from Quick Response code) is the trademark for a type of matrix barcode (or two-dimensional barcode)." Selection Now I am searching open source project on Github.  I use the key words "qrcode", set language as C. T...
Read more